Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: weblate badges to better fit repo guidelines [Weblate] #6712

Merged
merged 4 commits into from
Jul 10, 2021

Conversation

SethFalco
Copy link
Contributor

@SethFalco SethFalco commented Jul 4, 2021

  • Reduce the total badges and use the (...|...) syntax. (as mentioned above)

  • Replace /license with /l.

    License: /l

  • Default to https://hosted.weblate.org (it seems I can make server optional based on the docs)

    The parameter is for an uncommon optional attribute, like an alternate registry URL.

  • Review badge paths

    /SERVICE/NOUN/PARAMETERS?QUERYSTRING e.g: /github/issues/:user/:repo

- #6677 (comment)

Just let me know if there're any other problems!

image

Related Issues

@shields-ci
Copy link

shields-ci commented Jul 4, 2021

Messages
📖 ✨ Thanks for your contribution to Shields, @SethFalco!

Generated by 🚫 dangerJS against 4f87413

@shields-cd shields-cd temporarily deployed to shields-staging-pr-6712 July 5, 2021 02:30 Inactive
Copy link
Member

@calebcartwright calebcartwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! One minor topic for discussion left inline

services/weblate/weblate-entity-count.service.js Outdated Show resolved Hide resolved
@shields-cd shields-cd temporarily deployed to shields-staging-pr-6712 July 6, 2021 14:24 Inactive
@SethFalco
Copy link
Contributor Author

SethFalco commented Jul 6, 2021

Hoping I fixed everything up now.
Sorry again for the pain! ^-^'

Let me know if there're any other problems, and I'll address them up.

Weblate entity count

  • Changed title/file/class from Weblate entity count -> Weblate entities
  • Changed path from /weblate/count/{entities} -> /weblate/{entities}

Weblate user statistic

  • Changed file from weblate-user-statistics to weblate-user-statistic to match class/title. (whoops)
  • Changed path from /weblate/statistic/{user}/{entities} -> /weblate/{entities}/{user}
  • Request/badge now uses the appropriate verb everywhere, and uses a switch to translate it to select the correct property from the API response

Edit: Unfortunately, I'm unable to see why ci/dockercloud-stage failed. 🤔 (404)

@calebcartwright
Copy link
Member

Sorry for the delay, will look at this one later today. Could you rebase/address the merge conflicts when you get a chance?

Edit: Unfortunately, I'm unable to see why ci/dockercloud-stage failed. thinking (404)

Don't worry about this one, it's not a required check and has a history of being a bit of a flake. Docker also claim to be shutting this service down (refs #6634) thought they apparently either forgot or are running behind, and this could possibly be a symptom that they've finally done it

@shields-cd shields-cd temporarily deployed to shields-staging-pr-6712 July 9, 2021 19:10 Inactive
@shields-cd shields-cd had a problem deploying to shields-staging-pr-6712 July 9, 2021 19:16 Failure
@shields-cd shields-cd temporarily deployed to shields-staging-pr-6712 July 9, 2021 19:17 Inactive
@shields-cd shields-cd temporarily deployed to shields-staging-pr-6712 July 9, 2021 19:18 Inactive
@SethFalco
Copy link
Contributor Author

Excuse the mess, I messed up while rebasing and did a forced push which changed 20,000 lines. 😆 (cfb70fc)
I fixed it now, just spammed the PR activity a little. ^-^'

Copy link
Member

@calebcartwright calebcartwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Left a couple comments inline that could potentially be addressed in another follow up if you're interested, but I'm going to go ahead and merge this given the main goal of correcting the routes before anyone starts using the badge

@shields-cd shields-cd temporarily deployed to shields-staging-pr-6712 July 10, 2021 03:30 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants