Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use the right version of NPM in docker build #6941

Merged
merged 1 commit into from
Aug 24, 2021
Merged

use the right version of NPM in docker build #6941

merged 1 commit into from
Aug 24, 2021

Conversation

chris48s
Copy link
Member

Docker build was running using NPM 6. It was probably fine but generating some warnings. This ensures we're running 7 or above and lockfileVersion: 2 will definitely be parsed correctly.

@chris48s chris48s added the self-hosting Discussion, problems, features, and documentation related to self-hosting Shields label Aug 24, 2021
@shields-ci
Copy link

Messages
📖 ✨ Thanks for your contribution to Shields, @chris48s!

Generated by 🚫 dangerJS against ec6de36

calebcartwright
calebcartwright approved these changes Aug 24, 2021
View reviewed changes
Copy link
Member

@calebcartwright calebcartwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@repo-ranger repo-ranger bot merged commit 92772de into badges:master Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebcartwright calebcartwright calebcartwright approved these changes

Assignees
No one assigned
Labels
self-hosting Discussion, problems, features, and documentation related to self-hosting Shields
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chris48s @shields-ci @calebcartwright