make response headers more directly consumable with node-fetch #7168
+14
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebcartwright
added
core
|
calebcartwright
commented
Oct 17, 2021
Comment on lines
+90
to
+103
| const headers = Array.from(resp.headers.entries()).reduce( | ||
| (headers, [name, value]) => { | ||
| headers[name] = value | ||
| return headers | ||
| }, | ||
| {} | ||
| ) | ||
| return { | ||
| res: { | ||
| ...resp, | ||
| headers, | ||
| }, | ||
| buffer: body, | ||
| } |
There was a problem hiding this comment.
Probably worth parking for a bit and considering what, if any, potential impact this could have given that it'd currently occur on each and every request even though the vast majority of service classes don't really care about the response headers.
IIRC within v8 an Array.from is a by reference shallow copy so wouldn't expect that piece to necessitate any additional allocations/cpy's, though not opposed to instantiating the headers object upfront and then just using a .forEach( over the entries to insert the pairs.
Another option would be to only conditionally map the response headers if it's explicitly requested by the service class
Merged
|
Closing in favor of #7175 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7167