Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add [GitlabLanguageCount] service #8377

Merged
merged 4 commits into from
Oct 8, 2022
Merged

feat: add [GitlabLanguageCount] service #8377

merged 4 commits into from
Oct 8, 2022

Conversation

sunny0826
Copy link
Contributor

re #8077

@shields-ci
Copy link

shields-ci commented Sep 5, 2022 •
edited
Loading

Messages
📖 ✨ Thanks for your contribution to Shields, @sunny0826!

Generated by 🚫 dangerJS against d308c8b

@sunny0826 sunny0826 changed the title feat: add [GitlabLanguagesCount] service feat: add [GitlabLanguageCount] service Sep 5, 2022
@calebcartwright calebcartwright added the service-badge Accepted and actionable changes, features, and bugs label Sep 9, 2022
calebcartwright
calebcartwright reviewed Sep 26, 2022
View reviewed changes
Copy link
Member

@calebcartwright calebcartwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Couple minor items inline below

services/gitlab/gitlab-languages-count.service.js Outdated Show resolved Hide resolved
services/gitlab/gitlab-languages-count.service.js Outdated Show resolved Hide resolved
@sunny0826
fix
1552654 
Signed-off-by: guoxudong <guoxd@jihulab.com>
calebcartwright
calebcartwright approved these changes Oct 8, 2022
View reviewed changes
Copy link
Member

@calebcartwright calebcartwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@calebcartwright calebcartwright merged commit 05ab8a0 into badges:master Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebcartwright calebcartwright calebcartwright approved these changes

Assignees
No one assigned
Labels
service-badge Accepted and actionable changes, features, and bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sunny0826 @shields-ci @calebcartwright