add check for yaml app namespace (#621)

* add check for yaml app namespace * fix
baetyl · Nov 23, 2023 · cbf3071 · cbf3071
1 parent 7d8c91c
commit cbf3071
Showing 1 changed file with 9 additions and 0 deletions.
diff --git a/api/application.go b/api/application.go
@@ -758,6 +758,15 @@ func (api *API) validApplication(namespace string, app *models.ApplicationView)
 		}
 	}
 
+	if app.Type == specV1.AppTypeYaml || app.Type == specV1.AppTypeHelm {
+		if customNS, ok := app.Labels[specV1.CustomAppNsLabel]; customNS != "" && ok {
+			if customNS == context.EdgeSystemNamespace() || customNS == context.EdgeNamespace() {
+				return common.Error(common.ErrRequestParamInvalid,
+					common.Field("error", "custom namespace of yaml app is invalid(baetyl-edge/baetyl-edge-system)"))
+			}
+		}
+	}
+
 	app.Labels = common.AddSystemLabel(app.Labels, map[string]string{
 		common.LabelAppMode: app.Mode,
 	})