Add lock warpper for resource change. #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chensheng0
reviewed
Mar 24, 2021
common/context.go
Outdated
| @@ -148,6 +149,8 @@ func PopulateFailedResponse(cc *Context, err error, abort bool) { | |||
|
|
|||
| // HandlerFunc HandlerFunc | |||
| type HandlerFunc func(c *Context) (interface{}, error) | |||
| type LockFunc func(ctx context.Context, name string) (string, error) | |||
| type UnlockFunc func(ctx context.Context, name, value string) error | |||
chensheng0
reviewed
Mar 24, 2021
| func WrapperWithLock(lockFunc LockFunc, unlockFunc UnlockFunc) func(c *gin.Context) { | ||
| return func(c *gin.Context) { | ||
| cc := NewContext(c) | ||
| ctx := context.Background() |
chensheng0
reviewed
Mar 24, 2021
plugin/lock.go
Outdated
|
|
||
| // LockWithExpireTime lock the resource with expire time | ||
| // PARAMS: | ||
| // - name: the lock's name | ||
| // - expireTime(seconds): the expire time of the lock, if acquired the lock | ||
| // RETURNS: | ||
| // error: if has error else nil | ||
| LockWithExpireTime(name, value string, expireTime int64) error | ||
| LockWithExpireTime(ctx context.Context, name string, expireTime int64) (string, error) |
There was a problem hiding this comment.
ctx 来决定是否有超时时间，这俩接口留一个就行
Lock，一个接口
chensheng0
reviewed
Mar 24, 2021
service/locker.go
Outdated
| type LockerService interface { | ||
| Lock(ctx context.Context, name string) (string, error) | ||
| LockWithExpireTime(ctx context.Context, name string, expireTime int64) (string, error) | ||
| Unlock(ctx context.Context, name, value string) error |
Codecov Report
@@ Coverage Diff @@
## master #294 +/- ##
==========================================
- Coverage 66.46% 66.41% -0.05%
==========================================
Files 81 82 +1
Lines 5976 5982 +6
==========================================
+ Hits 3972 3973 +1
- Misses 1461 1465 +4
- Partials 543 544 +1
Continue to review full report at Codecov.
|
chensheng0
approved these changes
Mar 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.