Add with_gpu to manually build with/out gpu #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredcasper
reviewed
Jan 4, 2017
| ARCHIVE DESTINATION "${CMAKE_BINARY_DIR}") | ||
| RUNTIME DESTINATION "${CMAKE_INSTALL_PREFIX}/bin" | ||
| LIBRARY DESTINATION "${CMAKE_INSTALL_PREFIX}/lib" | ||
| ARCHIVE DESTINATION "${CMAKE_INSTALL_PREFIX}/lib") |
There was a problem hiding this comment.
The ${CMAKE_INSTALL_PREFIX}/ here is unnecessary, it can just be "bin", etc. Not sure why it was ever ${CMAKE_BINARY_DIR}
jaredcasper
reviewed
Jan 4, 2017
| LIBRARY DESTINATION "${CMAKE_INSTALL_PREFIX}/lib" | ||
| ARCHIVE DESTINATION "${CMAKE_INSTALL_PREFIX}/lib") | ||
|
|
||
| INSTALL(DIRECTORY include/ DESTINATION "${CMAKE_INSTALL_PREFIX}/include") |
There was a problem hiding this comment.
Is there a reason to install the entire include/ directory? I believe users should only need the include/ctc.h file.
There was a problem hiding this comment.
Yeah, we only need include/ctc.h. Thanks
|
@jaredcasper Thanks a lot. |
reyoung
reviewed
Jan 5, 2017
| @@ -53,7 +60,7 @@ ELSE() | |||
| ENDIF() | |||
|
|
|||
|
|
|||
| IF (CUDA_FOUND) | |||
| IF (WITH_GPU) | |||
|
|
|||
There was a problem hiding this comment.
Should we add a check when WITH_GPU=True and CUDA is not found? @gangliao
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#60