Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] 根组件有 if 指令时,没有输出数据 #146

Closed
meixg opened this issue Apr 14, 2022 · 1 comment · Fixed by #147
Closed

[BUG] 根组件有 if 指令时,没有输出数据 #146

meixg opened this issue Apr 14, 2022 · 1 comment · Fixed by #147
Labels

Comments

@meixg
Copy link
Collaborator

meixg commented Apr 14, 2022

Describe the bug

根组件有 if 指令时,在产出的 html 字符串中没有数据注释。

To Reproduce

var san = require('san');

var XP = san.defineComponent({
    template: '<p><slot/></p>'
});

var XA = san.defineComponent({
    template: '<a><slot/></a>'
});

var MyComponent = san.defineComponent({
    components: {
        'x-p': XP,
        'x-a': XA
    },
    template: '<x-p s-if="num"><b><span>{{num}}</span></b></x-p><x-a s-else><b>{{num}}</b></x-a>'
});

exports = module.exports = MyComponent;

应为:
<a><!--s-data:{"num":0}--><b>0</b></a>

得到:
<a><b>0</b></a>

github-actions bot pushed a commit that referenced this issue Apr 18, 2022
# [5.2.0](v5.1.0...v5.2.0) (2022-04-18)

### Bug Fixes

* revert "computed 应该在 inited 之前调用" [#144](#144) ([2b80c02](2b80c02))
* 根组件有 if 指令时,没有输出数据 [#146](#146) ([30b7f1c](30b7f1c))

### Features

* support [] while calling data methods ([30fd0dd](30fd0dd)), closes [#145](#145)
@github-actions
Copy link

🎉 This issue has been resolved in version 5.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant