Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partition routing not working properly #80

Closed
raminqaf opened this issue Sep 18, 2022 · 0 comments · Fixed by #77
Closed

Partition routing not working properly #80

raminqaf opened this issue Sep 18, 2022 · 0 comments · Fixed by #77
Assignees
Labels
component/gateway high priority Priotirized issues type/bug Something isn't working type/refactor Refactoring of existing functionality

Comments

@raminqaf
Copy link
Contributor

raminqaf commented Sep 18, 2022

Issue description

The partition routing in the gateway is not working properly for mirrors with range index. There are some bugs and problems I noticed while working with the partition routing more in-depth:

  1. The StreamsStateHost creates a wrong URL. So the request never arrives at the Mirror.

  2. The getResponseFromFallbackService method in MirrorRequestManagerWithFallback creates the wrong URL because it is ignoring the query parameters of the initial URL.

  3. The MirrorDataFetcherClient creates a PartitionedMirrorClient using the String SerDe. This causes that the partition calculation gets wrong. We need to know the type of the key that user is sending with its query request.

Expected Behavior

That the partition router updates the partition to host map correctly.

Current Behavior

The partition router in the gateway fails to fetch the information from a mirror and cannot access the correct mirror.

Steps to Reproduce

  1. Setup a gateway, mirror with range index
  2. send the first request to register the partition to host id
  3. kill the mirror to get a new ip
  4. send the request again
@raminqaf raminqaf added type/bug Something isn't working type/refactor Refactoring of existing functionality component/gateway labels Sep 18, 2022
@raminqaf raminqaf added this to Quick Sep 18, 2022
@raminqaf raminqaf moved this to In Progress in Quick Sep 21, 2022
@raminqaf raminqaf added the high priority Priotirized issues label Sep 21, 2022
@raminqaf raminqaf self-assigned this Sep 21, 2022
@raminqaf raminqaf moved this from In Progress to In-Review in Quick Sep 29, 2022
Repository owner moved this from In-Review to Done in Quick Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/gateway high priority Priotirized issues type/bug Something isn't working type/refactor Refactoring of existing functionality
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant