Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a test for MultiSubscriptionFetcher that encompasses complex types #87

Closed
DawidNiezgodka opened this issue Sep 22, 2022 · 0 comments · Fixed by #89
Closed

Create a test for MultiSubscriptionFetcher that encompasses complex types #87

DawidNiezgodka opened this issue Sep 22, 2022 · 0 comments · Fixed by #89
Assignees
@DawidNiezgodka
Labels
component/gateway

Comments

@DawidNiezgodka
Copy link
Contributor

For MultiSubscriptionFetcher we only have tests that involve string types.
In the scope of this issue, we want to add extra tests that encompass complex types (avro and proto).
@DawidNiezgodka DawidNiezgodka self-assigned this Sep 22, 2022
@DawidNiezgodka DawidNiezgodka moved this to In Progress in Quick Sep 23, 2022
@raminqaf raminqaf moved this from In Progress to Todo in Quick Sep 28, 2022
@DawidNiezgodka DawidNiezgodka mentioned this issue Sep 30, 2022
Merged
@raminqaf raminqaf moved this from Todo to In Progress in Quick Oct 5, 2022
@raminqaf raminqaf moved this from In Progress to In-Review in Quick Oct 11, 2022
raminqaf added a commit that referenced this issue Oct 13, 2022
@DawidNiezgodka @torbsto
@raminqaf @chrboehm
Multisubscription documentation with tests (#89)
7832df1 
PR for #85 and #87.

Co-authored-by: Torben Meyer <torben.meyer@bakdata.com>
Co-authored-by: Ramin Gharib <ramin.gharib@bakdata.com>
Co-authored-by: Christoph Böhm <christoph.boehm@bakdata.com>
@raminqaf raminqaf moved this from In-Review to Done in Quick Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DawidNiezgodka DawidNiezgodka

Labels
component/gateway
Projects
Quick
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Multisubscription documentation with tests bakdata/quick
2 participants
@raminqaf @DawidNiezgodka