Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keyArgument type sets the key serializer #150

Merged
merged 13 commits into from
Jan 13, 2023

Conversation

raminqaf
Copy link
Contributor

Closes #120

…y/key-argument-serializer

� Conflicts:
�	e2e/functional/key-range/result-range.json
�	e2e/functional/key-range/schema.gql
�	e2e/functional/key-range/tests.bats
…bakdata/quick into feature/gateway/key-argument-serializer
…y/key-argument-serializer

� Conflicts:
�	gateway/src/main/java/com/bakdata/quick/gateway/directives/topic/rule/fetcher/DataFetcherRule.java
�	gateway/src/main/java/com/bakdata/quick/gateway/fetcher/FetcherFactory.java
Copy link
Contributor

@torbsto torbsto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like quite a small change to me. Do you have a concrete alternative in mind that would be more elegant?

@raminqaf raminqaf requested a review from torbsto December 1, 2022 12:30
@raminqaf raminqaf marked this pull request as ready for review December 5, 2022 14:50
@raminqaf raminqaf merged commit 6399340 into master Jan 13, 2023
@raminqaf raminqaf deleted the feature/gateway/key-argument-serializer branch January 13, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gateway key serializer should be set by the keyArgument type
2 participants