Skip to content
This repository has been archived by the owner on Dec 3, 2021. It is now read-only.

Update dependency elm-review to v2.5.3 #118

Merged
merged 1 commit into from
Jun 20, 2021
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jun 20, 2021

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
elm-review 2.5.2 -> 2.5.3 age adoption passing confidence

Release Notes

jfmengels/node-elm-review

v2.5.3

Compare Source

There is a pretty big delay in calling elm-format when it's done through npx like we were doing. @​lydell made it so we don't use npx, which reduces the amount of time it takes to apply fixes. You'll notice it most when using --fix-all when a lot of files get changed.

The time spent calling elm-format went (when fixing 4 files) from about 1500ms to 300-400ms, and sometimes even around 150ms, depending on where elm-format is in your system.

This change is a bit scary, and it might break in some edge cases, but we don't expect anyone to be in those cases. If you do, please open an issue and temporarily go back to 2.5.2.

@​lydell also noticed a security issue when applying fixes (or rather, when spawning elm-format), in very special and unlikely circumstances.

  • Improve error message when entering an invalid rule name (#​48) 9ce7dd2

I also improved the error message when using non-ASCII characters in the rule name for new-package or new-rule. Thanks to @​lydell for noticing!

Thanks @​lydell for all the awesome work!


Configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot added the dependencies 🤝 Pull requests that update a dependency file label Jun 20, 2021
@bakseter bakseter merged commit 7819b70 into develop Jun 20, 2021
@renovate renovate bot deleted the renovate/elm-review-2.x branch June 20, 2021 17:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies 🤝 Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants