This repository has been archived by the owner on Dec 3, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
2.5.2
->2.5.3
Release Notes
jfmengels/node-elm-review
v2.5.3
Compare Source
elm-format
by not usingnpx
(#49)5669aef
There is a pretty big delay in calling
elm-format
when it's done throughnpx
like we were doing. @lydell made it so we don't usenpx
, which reduces the amount of time it takes to apply fixes. You'll notice it most when using--fix-all
when a lot of files get changed.The time spent calling
elm-format
went (when fixing 4 files) from about 1500ms to 300-400ms, and sometimes even around 150ms, depending on whereelm-format
is in your system.This change is a bit scary, and it might break in some edge cases, but we don't expect anyone to be in those cases. If you do, please open an issue and temporarily go back to 2.5.2.
0751825
@lydell also noticed a security issue when applying fixes (or rather, when spawning elm-format), in very special and unlikely circumstances.
9ce7dd2
I also improved the error message when using non-ASCII characters in the rule name for
new-package
ornew-rule
. Thanks to @lydell for noticing!Thanks @lydell for all the awesome work!
Configuration
📅 Schedule: At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by WhiteSource Renovate. View repository job log here.