Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore Root Gauge Mocks #2546

Merged
merged 2 commits into from
Sep 5, 2023
Merged

Restore Root Gauge Mocks #2546

merged 2 commits into from
Sep 5, 2023

Conversation

EndymionJkb
Copy link
Collaborator

Description

Root Gauge Mocks are required for the fork tests of some root gauges (e.g., Avalanche). They are not used in the monorepo, but need to be in the build-info for the deployment fork tests to work.

There is a way to import them into the deployments repo (e.g., src/contracts/helpers), but this is undesirable, as the mock contracts are directly dependent on the root gauges themselves, and we do not want to introduce a dependency on liquidity-mining in the deployments repo.

So, the compromise is to leave them in the monorepo, and document in both places where the files are coming from.

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Dependency changes
  • Code refactor / cleanup
  • Documentation or wording changes
  • Other

Checklist:

  • The diff is legible and has no extraneous changes
  • [N/A] Complex code has been commented, including external interfaces
  • [N/A] Tests are included for all code paths
  • The base branch is either master, or there's a description of how to merge

Issue Resolution

Copy link
Contributor

@jubeira jubeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 ♻️

@EndymionJkb EndymionJkb merged commit 683f480 into master Sep 5, 2023
13 of 16 checks passed
@EndymionJkb EndymionJkb deleted the mock-thrashing branch September 5, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants