-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stakeless gauge checkpointer: generic cost gauges #2547
Stakeless gauge checkpointer: generic cost gauges #2547
Conversation
- Allow generic paid types other than Arbitrum. - API to checkpoint by types, get cost by types.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have some suggestions for a little more refactoring
pkg/interfaces/contracts/liquidity-mining/IStakelessGaugeCheckpointer.sol
Outdated
Show resolved
Hide resolved
pkg/liquidity-mining/contracts/gauges/StakelessGaugeCheckpointer.sol
Outdated
Show resolved
Hide resolved
pkg/liquidity-mining/contracts/gauges/StakelessGaugeCheckpointer.sol
Outdated
Show resolved
Hide resolved
pkg/liquidity-mining/contracts/gauges/StakelessGaugeCheckpointer.sol
Outdated
Show resolved
Hide resolved
pkg/liquidity-mining/contracts/gauges/StakelessGaugeCheckpointer.sol
Outdated
Show resolved
Hide resolved
pkg/liquidity-mining/contracts/gauges/StakelessGaugeCheckpointer.sol
Outdated
Show resolved
Hide resolved
pkg/liquidity-mining/contracts/gauges/StakelessGaugeCheckpointer.sol
Outdated
Show resolved
Hide resolved
Co-authored-by: EndymionJkb <EndymionJkb@gmail.com>
Thanks for the review! Could you please take one more look at the latest changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now. (One small comment nit: a pet peeve :)
pkg/liquidity-mining/contracts/gauges/StakelessGaugeCheckpointer.sol
Outdated
Show resolved
Hide resolved
…er.sol Co-authored-by: EndymionJkb <EndymionJkb@gmail.com>
Description
This PR makes the stakeless gauge checkpointer more future proof and flexible, while making it compatible with the new avax gauges.
Summary of the changes:
Type of change
Checklist:
master
, or there's a description of how to mergeIssue Resolution
N/A