Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing function Batch Relayer V6 #2550

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Missing function Batch Relayer V6 #2550

merged 1 commit into from
Oct 27, 2023

Conversation

EndymionJkb
Copy link
Collaborator

Description

Discovered during deployment preparation that the relayer now deploys two contracts: BalancerRelayer, and the new query library contract. In order to verify the query library (and the BalancerRelayer, which takes it as an argument), we need to expose the address of the query library.

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Dependency changes
  • Code refactor / cleanup
  • Documentation or wording changes
  • Other

Checklist:

  • The diff is legible and has no extraneous changes
  • [N/A] Complex code has been commented, including external interfaces
  • Tests are included for all code paths
  • The base branch is either master, or there's a description of how to merge

Issue Resolution

Copy link
Contributor

@jubeira jubeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Real programmers would read from storage or calculate the address by hand, but ok 😛

@EndymionJkb
Copy link
Collaborator Author

Real programmers would read from storage or calculate the address by hand, but ok 😛

I knew a guy in college who went a little nuts with defining hot keys in Emacs. I used to joke that I was afraid to use his key bindings, for fear I'd hit the wrong one and accidentally launch the space shuttle.

Sorry I wasn't able to do it with all zeroes.

@jubeira jubeira merged commit df3e08e into master Oct 27, 2023
16 checks passed
@jubeira jubeira deleted the relayer-v6-tweak branch October 27, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants