Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support "recovery" exits from stable phantom pools #2555

Closed
wants to merge 2 commits into from

Conversation

EndymionJkb
Copy link
Collaborator

Description

We noted that the relayer doesn't support "recovery" exits from StablePhantom pools. I believe this was omitted because such exits are only supported when the pools are paused, and the original StablePhantom pools are past their pause window. So this would really only be needed if someone redeployed the factory (e.g., on a new L2). (Or, I suppose, if someone were fork testing something in an old block within the pause window.)

Mostly a dotting i's, crossing t's thing, since V5 was supposed to support all stable pool types but (understandably / deliberately) left out StablePhantoms: and included a test for them that didn't actually test the relayer.

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Dependency changes
  • Code refactor / cleanup
  • Documentation or wording changes
  • Other

Checklist:

  • The diff is legible and has no extraneous changes
  • Complex code has been commented, including external interfaces
  • Tests are included for all code paths (there is a working fork test in deployments, based off this build)
  • The base branch is either master, or there's a description of how to merge

Issue Resolution

@EndymionJkb
Copy link
Collaborator Author

Not supported

@EndymionJkb EndymionJkb closed this Nov 9, 2023
@jubeira jubeira deleted the support-phantom-stable branch November 9, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant