Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hook moduleloader does not work with private npm modules #3022

Closed
tjwebb opened this issue Jun 19, 2015 · 0 comments · Fixed by #3023
Closed

hook moduleloader does not work with private npm modules #3022

tjwebb opened this issue Jun 19, 2015 · 0 comments · Fixed by #3023
Labels
bug

Comments

@tjwebb
Copy link
Contributor

tjwebb commented Jun 19, 2015

https://github.com/balderdashy/sails/blob/master/lib/hooks/moduleloader/index.js#L444

private npm modules are installed one level below node_modules. e.g. for the user "balderdash", a module is installed innode_modules/@balderdash/`. The sails hook module loader does not seem to pick these up.

Changing "depth" to 3 doesn't seem to magically fix anything. I'm looking into it now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

support npm private modules as hooks tjwebb/sails
1 participant
@tjwebb