Mocha 5: Sails is failing to lift inside Mocha tests due captains-log issue #4395

leosuncin · 2018-05-08T05:20:38Z

Sails version: 1.0.1
Node version: 10.0.0
NPM version: 6.0.0
DB adapter name: N/A
DB adapter version: N/A
Operating system: Linux 4.14.36-1-MANJARO x86_64

I'm using mocha for run my E2E against my API (WIP) build it with sails and I followed the steps on the documentation, but I'm getting a error when try to lift sails via mocha (if I run sails lift outside mocha works).

Stack trace

/home/leosuncin/Workspaces/github/writtr-api/node_modules/captains-log/lib/configure.js:196
        else if (colorName.match(/^dim/)) {
                           ^
TypeError: Cannot read property 'match' of undefined

at _getColorizedPrefix (/home/leosuncin/Workspaces/github/writtr-api/node_modules/captains-log/lib/configure.js:196:28)

at /home/leosuncin/Workspaces/github/writtr-api/node_modules/captains-log/lib/configure.js:208:9

at Array.forEach ()

at module.exports (/home/leosuncin/Workspaces/github/writtr-api/node_modules/captains-log/lib/configure.js:134:21)

at CaptainsLog (/home/leosuncin/Workspaces/github/writtr-api/node_modules/captains-log/index.js:39:17)

at Object. (/home/leosuncin/Workspaces/github/writtr-api/node_modules/sails/errors/fatal.js:11:11)

at Module._compile (internal/modules/cjs/loader.js:678:30)

at Object.Module._extensions..js (internal/modules/cjs/loader.js:689:10)

at Module.load (internal/modules/cjs/loader.js:589:32)

at tryModuleLoad (internal/modules/cjs/loader.js:528:12)

at Function.Module._load (internal/modules/cjs/loader.js:520:3)

at Module.require (internal/modules/cjs/loader.js:626:17)

at require (internal/modules/cjs/helpers.js:20:18)

at Object. (/home/leosuncin/Workspaces/github/writtr-api/node_modules/sails/errors/index.js:3:10)

at Module._compile (internal/modules/cjs/loader.js:678:30)

at Object.Module._extensions..js (internal/modules/cjs/loader.js:689:10)

at Module.load (internal/modules/cjs/loader.js:589:32)

at tryModuleLoad (internal/modules/cjs/loader.js:528:12)

at Function.Module._load (internal/modules/cjs/loader.js:520:3)

at Module.require (internal/modules/cjs/loader.js:626:17)

at require (internal/modules/cjs/helpers.js:20:18)

at Object. (/home/leosuncin/Workspaces/github/writtr-api/node_modules/sails/lib/app/private/isLocalSailsValid.js:9:11)

at Module._compile (internal/modules/cjs/loader.js:678:30)

at Object.Module._extensions..js (internal/modules/cjs/loader.js:689:10)

at Module.load (internal/modules/cjs/loader.js:589:32)

at tryModuleLoad (internal/modules/cjs/loader.js:528:12)

at Function.Module._load (internal/modules/cjs/loader.js:520:3)

at Module.require (internal/modules/cjs/loader.js:626:17)

at require (internal/modules/cjs/helpers.js:20:18)

at Object. (/home/leosuncin/Workspaces/github/writtr-api/node_modules/sails/lib/app/Sails.js:162:37)

at Module._compile (internal/modules/cjs/loader.js:678:30)

at Object.Module._extensions..js (internal/modules/cjs/loader.js:689:10)

at Module.load (internal/modules/cjs/loader.js:589:32)

at tryModuleLoad (internal/modules/cjs/loader.js:528:12)

at Function.Module._load (internal/modules/cjs/loader.js:520:3)

at Module.require (internal/modules/cjs/loader.js:626:17)

at require (internal/modules/cjs/helpers.js:20:18)

at Object. (/home/leosuncin/Workspaces/github/writtr-api/node_modules/sails/lib/app/index.js:6:13)

at Module._compile (internal/modules/cjs/loader.js:678:30)

at Object.Module._extensions..js (internal/modules/cjs/loader.js:689:10)

at Module.load (internal/modules/cjs/loader.js:589:32)

at tryModuleLoad (internal/modules/cjs/loader.js:528:12)

at Function.Module._load (internal/modules/cjs/loader.js:520:3)

at Module.require (internal/modules/cjs/loader.js:626:17)

at require (internal/modules/cjs/helpers.js:20:18)

at Object. (/home/leosuncin/Workspaces/github/writtr-api/node_modules/sails/lib/index.js:5:13)

at Module._compile (internal/modules/cjs/loader.js:678:30)

at Object.Module._extensions..js (internal/modules/cjs/loader.js:689:10)

at Module.load (internal/modules/cjs/loader.js:589:32)

at tryModuleLoad (internal/modules/cjs/loader.js:528:12)

at Function.Module._load (internal/modules/cjs/loader.js:520:3)

at Module.require (internal/modules/cjs/loader.js:626:17)

at require (internal/modules/cjs/helpers.js:20:18)

at Object. (/home/leosuncin/Workspaces/github/writtr-api/test/bootstrap.js:2:17)

at Module._compile (internal/modules/cjs/loader.js:678:30)

at Object.Module._extensions..js (internal/modules/cjs/loader.js:689:10)

at Module.load (internal/modules/cjs/loader.js:589:32)

at tryModuleLoad (internal/modules/cjs/loader.js:528:12)

at Function.Module._load (internal/modules/cjs/loader.js:520:3)

at Module.require (internal/modules/cjs/loader.js:626:17)

at require (internal/modules/cjs/helpers.js:20:18)

at /home/leosuncin/Workspaces/github/writtr-api/node_modules/mocha/lib/mocha.js:253:27

at Array.forEach ()

at Mocha.loadFiles (/home/leosuncin/Workspaces/github/writtr-api/node_modules/mocha/lib/mocha.js:250:14)

at Mocha.run (/home/leosuncin/Workspaces/github/writtr-api/node_modules/mocha/lib/mocha.js:577:10)

at Object. (/home/leosuncin/Workspaces/github/writtr-api/node_modules/mocha/bin/_mocha:591:18)

at Module._compile (internal/modules/cjs/loader.js:678:30)

at Object.Module._extensions..js (internal/modules/cjs/loader.js:689:10)

at Module.load (internal/modules/cjs/loader.js:589:32)

at tryModuleLoad (internal/modules/cjs/loader.js:528:12)

at Function.Module._load (internal/modules/cjs/loader.js:520:3)

at Function.Module.runMain (internal/modules/cjs/loader.js:719:10)

at startup (internal/bootstrap/node.js:228:19)

at bootstrapNodeJSCore (internal/bootstrap/node.js:575:3)

Is an issue related to captains-log and can be fixed with:

node_modules/captains-log/lib/configure.js
156c156
<       var colorName = colorMappings[logAt];
---
>       var colorName = colorMappings[logAt] || DEFAULT.OVERRIDES.colors[logAt];

You can see my repo with the issue here https://github.com/leosuncin/writtr-api-sails/tree/testing

The text was updated successfully, but these errors were encountered:

sailsbot · 2018-05-08T05:20:56Z

@leosuncin Thanks for posting, we'll take a look as soon as possible.

For help with questions about Sails, click here. If you’re interested in hiring @sailsbot and her minions in Austin, click here.

mikermcneil · 2018-05-30T22:43:16Z

@leosuncin thanks! And, interesting- we use mocha 3.0.2 across the board over here and so hadn't noticed this. When time allows, I'll try to recreate this with mocha 5

leosuncin · 2018-06-04T02:56:31Z

@mikermcneil please review this, I can't use CI/CD due the tests won't run successfully even if are right.

mikermcneil · 2018-06-25T20:29:29Z

@leosuncin 👍 see balderdashy/captains-log#22 (comment)

mikermcneil · 2018-06-25T20:30:39Z

published as captains-log@2.0.1

leosuncin mentioned this issue May 29, 2018

Jasmine + SailsJS Unit Tests #4424

Closed

mikermcneil added the 3rd party package label May 30, 2018

mikermcneil changed the title ~~Sails is failing to lift inside Mocha tests due captains-log issue~~ Sails is failing to lift inside Mocha tests due captains-log issue (Mocha 5) May 30, 2018

mikermcneil changed the title ~~Sails is failing to lift inside Mocha tests due captains-log issue (Mocha 5)~~ Mocha 5: Sails is failing to lift inside Mocha tests due captains-log issue May 30, 2018

leosuncin linked a pull request Jun 4, 2018 that will close this issue

Use default colorName when configure captains-log balderdashy/captains-log#22

Open

mikermcneil added a commit to balderdashy/captains-log that referenced this issue Jun 25, 2018

Add failsafe re balderdashy/sails#4395 and #22

5f6ecfd

mikermcneil added the patched label Jun 25, 2018

johnabrams7 added the resolved label Apr 15, 2019

mikermcneil added resolved and removed resolved patched labels Apr 22, 2019

This was referenced Mar 12, 2020

[Snyk] Fix for 1 vulnerabilities ahmed-medhat-tawfiq/sails#15

Open

[Snyk] Fix for 1 vulnerabilities marchfederico/sails#18

Open

This was referenced Mar 23, 2022

[Snyk] Fix for 1 vulnerabilities ahmed-medhat-tawfiq/sails#25

Open

[Snyk] Fix for 1 vulnerabilities marchfederico/sails#28

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mocha 5: Sails is failing to lift inside Mocha tests due captains-log issue #4395

Mocha 5: Sails is failing to lift inside Mocha tests due captains-log issue #4395

leosuncin commented May 8, 2018

sailsbot commented May 8, 2018

mikermcneil commented May 30, 2018

leosuncin commented Jun 4, 2018

mikermcneil commented Jun 25, 2018

mikermcneil commented Jun 25, 2018

Mocha 5: Sails is failing to lift inside Mocha tests due captains-log issue #4395

Mocha 5: Sails is failing to lift inside Mocha tests due captains-log issue #4395

Comments

leosuncin commented May 8, 2018

sailsbot commented May 8, 2018

mikermcneil commented May 30, 2018

leosuncin commented Jun 4, 2018

mikermcneil commented Jun 25, 2018

mikermcneil commented Jun 25, 2018