[feature] Add configuration to csrf to be able to change default /csrfTo... #2367
Conversation
| }); | ||
| } | ||
| // Create a route path for getting _csrf parameter | ||
| var csrfRoute = {}; | ||
| csrfRoute[sails.config.csrf.route] = {target: csrfToken, cors: {origin: sails.config.csrf.origin, credentials:true}}; |
There was a problem hiding this comment.
Can you make this line more readable please (indent)?
|
Looks good to me. Can you write a test for this new feature please? Then, I will merge it. |
|
@konstantinzolotarev @loicsaintroch Closing for now- please feel free to reopen w/ test(s) |
|
@mikermcneil @loicsaintroch Seems that I couldn't open this pull request and update it. Should I create a new one or you will open this one ? |
|
@mikermcneil @sgress454 @loicsaintroch Might be we could include this enchantment into new sails version ? |
|
Looks good to me. What do you think @mikermcneil @sgress454 ? |
|
@konstantinzolotarev @loicsaintroch thanks! Looks like it needs a rebase (but also travis is being crazy) If travis calms down (tests pass + merge can be performed automatically), can merge this afternoon |
|
@konstantinzolotarev please see #2367 (comment) -- this refactor introduces potential entanglement issues |
Conflicts: CHANGELOG.md lib/app/getBaseurl.js
|
@mikermcneil Sorry for long response. Was in a trip. |
|
Looks good to me. Ok to merge this feature @mikermcneil @sgress454 ? |
|
Bump~ |
|
@konstantinzolotarev thanks! If you wouldn't mind rebasing so we can auto-merge, we can go ahead and do that. |
Conflicts: CHANGELOG.md
|
@mikermcneil done |
Add configuration to csrf to be able to change default /csrfToken
|
Thank you very much for your contribution @konstantinzolotarev, we appreciate your support. |
...ken route #2366