Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused validation of cast to imported anon type #30410

Merged
merged 1 commit into from
May 7, 2021

Conversation

MaryamZi
Copy link
Member

@MaryamZi MaryamZi commented May 7, 2021

Purpose

$title. No longer required with the changes in #29792.

@MaryamZi MaryamZi added the Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times. label May 7, 2021
@MaryamZi MaryamZi requested a review from grainier May 7, 2021 02:14
@MaryamZi MaryamZi force-pushed the remove-unused-code branch from 1d11187 to 1505853 Compare May 7, 2021 02:20
@codecov
Copy link

codecov bot commented May 7, 2021

Codecov Report

Merging #30410 (1505853) into master (344527d) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #30410      +/-   ##
============================================
+ Coverage     68.23%   68.25%   +0.02%     
+ Complexity    37298    37297       -1     
============================================
  Files          2895     2895              
  Lines        158485   158432      -53     
  Branches      19718    19707      -11     
============================================
- Hits         108144   108141       -3     
+ Misses        44003    43951      -52     
- Partials       6338     6340       +2     
Impacted Files Coverage Δ Complexity Δ
...g/wso2/ballerinalang/compiler/desugar/Desugar.java 86.20% <ø> (+0.89%) 918.00 <0.00> (ø)
.../java/io/ballerina/projects/PackageResolution.java 86.86% <0.00%> (-2.03%) 31.00% <0.00%> (ø%)
...ang/compiler/semantics/model/types/BUnionType.java 79.14% <0.00%> (-1.43%) 85.00% <0.00%> (-2.00%)
...runtime/internal/scheduling/WorkerDataChannel.java 88.53% <0.00%> (+0.63%) 34.00% <0.00%> (ø%)
.../ballerina/runtime/internal/scheduling/Strand.java 81.11% <0.00%> (+1.66%) 45.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8be01a4...1505853. Read the comment docs.

@grainier grainier merged commit cfafd86 into ballerina-platform:master May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants