Improved diagnostic rendering #42282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jline 3.25.1 which is the latest at time of writing, breaks most of our test cases related ballerina shell. After testing around it seems that this is caused by the dumbterminal. Even though tests failed the bal shell command seems to work as usual. There is no mention of this issue on jline's issues and I was not able to reproduce it in a sample java project. The version bump I needed to access jansi from within jline happened in jline 3.25.0, therefore instead of 3.25.1 I changed it back to 3.25.0 until we find a way to change our test cases or jline's future updates.
RadCod3
requested review from
hevayo,
sameerajayasoma and
hasithaa
as code owners
LakshanWeerasinghe
merged commit 9b9195c
into
ballerina-platform:improve-diagnostic-output
12 of 18 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Related to #42236.
This PR is to make some fixes for some stdlib test failures.