[Step Extension] Add semantic support xml step extension #43106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdulmina
reviewed
Jul 16, 2024
...rina-lang/src/main/java/org/wso2/ballerinalang/compiler/semantics/analyzer/CodeAnalyzer.java
Outdated
Show resolved
Hide resolved
compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/desugar/Desugar.java
Outdated
Show resolved
Hide resolved
compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/desugar/Desugar.java
Outdated
Show resolved
Hide resolved
compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/desugar/Desugar.java
Outdated
Show resolved
Hide resolved
...er/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/parser/BLangNodeBuilder.java
Outdated
Show resolved
Hide resolved
...er/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/parser/BLangNodeBuilder.java
Outdated
Show resolved
Hide resolved
poorna2152
force-pushed
the
xml_step_extend_method_invocation
branch
from
ab2f29f
to
1d1a38f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## xml_step_extension #43106 +/- ##
========================================================
- Coverage 77.35% 77.35% -0.01%
- Complexity 58300 58720 +420
========================================================
Files 3454 3469 +15
Lines 219173 220387 +1214
Branches 28741 28933 +192
========================================================
+ Hits 169544 170477 +933
- Misses 40295 40490 +195
- Partials 9334 9420 +86 ☔ View full report in Codecov by Sentry. |
poorna2152
requested review from
heshanpadmasiri,
rdulmina,
MaryamZi,
chiranSachintha,
lochana-chathura,
SasinduDilshara and
LakshanWeerasinghe
MaryamZi
reviewed
Jul 22, 2024
| @Override | ||
| public void visit(BLangXMLFilterStepExtend xmlFilterStepExtend) { | ||
| lookupNodes(xmlFilterStepExtend.filters); | ||
| } |
There was a problem hiding this comment.
Can we check if we can fix the codecov warnings?
| public void visit(BLangExtendedXMLNavigationAccess extendedXMLNavigationAccess) { | ||
| extendedXMLNavigationAccess.stepExpr = rewriteExpr(extendedXMLNavigationAccess.stepExpr); | ||
| result = extendedXMLNavigationAccess; | ||
| } |
There was a problem hiding this comment.
We need to check codecov warnings everywhere.
compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/parser/NodeCloner.java
Outdated
Show resolved
Hide resolved
| @@ -2310,6 +2314,24 @@ public void visit(BLangXMLElementFilter source) { | |||
| source.cloneRef = clone; | |||
| } | |||
|
|
|||
| @Override | |||
| public void visit(BLangXMLIndexedStepExtend source) { | |||
| BLangXMLIndexedStepExtend clone = new BLangXMLIndexedStepExtend(source.pos, source.indexExpr); | |||
.../java/org/wso2/ballerinalang/compiler/tree/expressions/BLangExtendedXMLNavigationAccess.java
Show resolved
Hide resolved
tests/jballerina-unit-test/src/test/java/org/ballerinalang/test/types/xml/XMLAccessTest.java
Outdated
Show resolved
Hide resolved
compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/desugar/Desugar.java
Outdated
Show resolved
Hide resolved
|
This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the |
|
This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the |
poorna2152
force-pushed
the
xml_step_extend_method_invocation
branch
from
6247968
to
9152736
Compare
poorna2152
force-pushed
the
xml_step_extend_method_invocation
branch
from
9152736
to
6bf09d9
Compare
poorna2152
force-pushed
the
xml_step_extension
branch
from
2e1e1be
to
dac4c7a
Compare
poorna2152
force-pushed
the
xml_step_extend_method_invocation
branch
2 times, most recently
from
6c6ff0e
to
a969212
Compare
poorna2152
force-pushed
the
xml_step_extend_method_invocation
branch
from
a969212
to
5e9ee97
Compare
poorna2152
force-pushed
the
xml_step_extend_method_invocation
branch
from
b2bb60f
to
317e292
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
$subject
Approach
Samples
Remarks
Check List