Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Convention Plugins and Version Catalog #43392

Merged
merged 4 commits into from
Oct 4, 2024

Conversation

Shadow-Devil
Copy link
Contributor

Purpose

Gradle recommends to structure build logic into convention plugins which is very similar to the current approach but it is different, how the plugins are applied.
Before:

apply from: "$rootDir/gradle/javaProject.gradle"
apply from: "$rootDir/gradle/ballerinaLangLibLoad.gradle"

After:

plugins {
    id 'javaProject'
    id 'ballerinaLangLibLoad'
}

This also introduces a version catalog as a toml file, where all dependencies are centrally managed and can then be used via the libs property. e.g. libs.testng is the testng dependency.

References:

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@8100e00). Learn more about missing BASE report.
Report is 96 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #43392   +/-   ##
=========================================
  Coverage          ?   77.49%           
  Complexity        ?    58570           
=========================================
  Files             ?     3438           
  Lines             ?   219204           
  Branches          ?    28912           
=========================================
  Hits              ?   169879           
  Misses            ?    39908           
  Partials          ?     9417           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Shadow-Devil Shadow-Devil force-pushed the convention-plugins branch 2 times, most recently from 35b87bb to 80cdcea Compare September 16, 2024 17:14
@Shadow-Devil Shadow-Devil changed the title Use Convention Plugins Use Convention Plugins and Version Catalog Sep 16, 2024
gradle/plugins/settings.gradle Outdated Show resolved Hide resolved
gradle/plugins/java-convention/build.gradle Outdated Show resolved Hide resolved
ballerina-shell/modules/shell-rt/build.gradle Outdated Show resolved Hide resolved
ballerina-shell/modules/shell-cli/build.gradle Outdated Show resolved Hide resolved
ballerina-shell/modules/shell-cli/build.gradle Outdated Show resolved Hide resolved
ballerina-shell/modules/shell-core/build.gradle Outdated Show resolved Hide resolved
@gimantha gimantha merged commit 42ec3a5 into ballerina-platform:master Oct 4, 2024
18 checks passed
@Shadow-Devil Shadow-Devil deleted the convention-plugins branch October 4, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants