-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Convention Plugins and Version Catalog #43392
Merged
gimantha
merged 4 commits into
ballerina-platform:master
from
Shadow-Devil:convention-plugins
Oct 4, 2024
Merged
Use Convention Plugins and Version Catalog #43392
gimantha
merged 4 commits into
ballerina-platform:master
from
Shadow-Devil:convention-plugins
Oct 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shadow-Devil
requested review from
hevayo,
sameerajayasoma,
warunalakshitha,
mohanvive and
hasithaa
as code owners
September 13, 2024 18:31
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #43392 +/- ##
=========================================
Coverage ? 77.49%
Complexity ? 58570
=========================================
Files ? 3438
Lines ? 219204
Branches ? 28912
=========================================
Hits ? 169879
Misses ? 39908
Partials ? 9417 ☔ View full report in Codecov by Sentry. |
gimantha
reviewed
Sep 14, 2024
gradle/plugins/java-convention/src/main/groovy/javaLibsProject.gradle
Outdated
Show resolved
Hide resolved
gimantha
reviewed
Sep 14, 2024
gradle/plugins/java-convention/src/main/groovy/javaProject.gradle
Outdated
Show resolved
Hide resolved
gimantha
reviewed
Sep 14, 2024
Shadow-Devil
force-pushed
the
convention-plugins
branch
2 times, most recently
from
September 16, 2024 17:14
35b87bb
to
80cdcea
Compare
Shadow-Devil
changed the title
Use Convention Plugins
Use Convention Plugins and Version Catalog
Sep 16, 2024
Shadow-Devil
force-pushed
the
convention-plugins
branch
from
September 18, 2024 13:18
80cdcea
to
cbe5fd4
Compare
Shadow-Devil
requested review from
MaryamZi,
KavinduZoysa,
azinneera,
NipunaRanasinghe and
Dilhasha
as code owners
September 18, 2024 13:18
gimantha
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Gradle recommends to structure build logic into convention plugins which is very similar to the current approach but it is different, how the plugins are applied.
Before:
After:
This also introduces a version catalog as a toml file, where all dependencies are centrally managed and can then be used via the
libs
property. e.g.libs.testng
is the testng dependency.References:
Check List