Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java 21] Remove the use of SLF4J from Ballerina Runtime #43407

Draft
wants to merge 5 commits into
base: java21
Choose a base branch
from

Conversation

ravinperera00
Copy link
Contributor

@ravinperera00 ravinperera00 commented Sep 22, 2024

Purpose

$subject

Approach

The suggested changes will refactor the code to remove the use of SLF4J library methods and classes from the Ballerina Runtime using other Java alternatives.

Remarks

Planning to format the log output including the stacktrace to match the previous template later.

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@ravinperera00 ravinperera00 marked this pull request as ready for review September 22, 2024 13:17
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 75.00%. Comparing base (fea2118) to head (84069be).
Report is 3 commits behind head on java21.

Files with missing lines Patch % Lines
...ntime/transactions/TransactionResourceManager.java 0.00% 14 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             java21   #43407      +/-   ##
============================================
- Coverage     75.00%   75.00%   -0.01%     
+ Complexity    56729    56719      -10     
============================================
  Files          3447     3447              
  Lines        218874   218867       -7     
  Branches      28846    28844       -2     
============================================
- Hits         164177   164159      -18     
- Misses        45743    45753      +10     
- Partials       8954     8955       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@warunalakshitha
Copy link
Contributor

Can we remove from rt jar

@ravinperera00 ravinperera00 marked this pull request as draft November 4, 2024 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants