Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress the IllegalArgumentException thrown when creating a new annotation #349

Conversation

ThemiraChathumina
Copy link
Contributor

Purpose

Triggering code actions without a diagnostic context currently results in an IllegalArgumentException. This fix will ensure that the corresponding IDE error message is suppressed.

Related to #278

Approach

Gracefully handle IllegalArgumentException within a try-catch block. This error will be thrown when creating a new annotation object to display the relevant code action.

@CLAassistant
Copy link

CLAassistant commented Mar 28, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@NipunaRanasinghe NipunaRanasinghe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note that we've temporarily suppressed the exception to omit plugin crash logs, until a proper fix arrives

@NipunaRanasinghe NipunaRanasinghe merged commit 8643580 into ballerina-platform:master Apr 1, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants