Added fullscreen support to the camera stream view on macOS #3974
+206
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 28, 2024 09:46
Modified wxMediaCtrl2 to use NSView::enterFullScreenMode and exitFullScreenModeWithOptions to toggle fullscreen. You can enter/exit by clicking on the video and pressing escape. A fullscreen button was also added as an overlay to the video view that can be used to enter/exit fullscreen.
|
Is there a solution on the Windows platform?
… From: ***@***.***>
Date: Mon, May 6, 2024, 11:02
Subject: Re: [bambulab/BambuStudio] Added fullscreen support to the camera stream view on macOS (PR #3974)
To: ***@***.***>
Cc: ***@***.***>, "Review ***@***.***>
@lanewei120<https://github.com/lanewei120> requested your review on: #3974<#3974> Added fullscreen support to the camera stream view on macOS.
—
Reply to this email directly, view it on GitHub<#3974 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A22TCGFMX5BAG6R7FC3DH4DZA3XCZAVCNFSM6AAAAABG5FV7H6VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJSG4YDSMZZGU3DQMA>.
You are receiving this because your review was requested.[image: https://github.com/notifications/beacon/A22TCGBMXDCCMKL7BE6MMGLZA3XCZA5CNFSM6AAAAABG5FV7H6WGG33NNVSW45C7OR4XAZNWJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XKUY3PNVWWK3TUL5UWJTYAAAAAF5MJ7TQA.gif]Message ID: ***@***.***>
|
![https://github.com/notifications/beacon/A22TCGBMXDCCMKL7BE6MMGLZA3XCZA5CNFSM6AAAAABG5FV7H6WGG33NNVSW45C7OR4XAZNWJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XKUY3PNVWWK3TUL5UWJTYAAAAAF5MJ7TQA.gif]Message](https://github.com/notifications/beacon/A22TCGBMXDCCMKL7BE6MMGLZA3XCZA5CNFSM6AAAAABG5FV7H6WGG33NNVSW45C7OR4XAZNWJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XKUY3PNVWWK3TUL5UWJTYAAAAAF5MJ7TQA.gif]Message){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified wxMediaCtrl2 to use NSView::enterFullScreenMode and exitFullScreenModeWithOptions to toggle fullscreen.
You can enter/exit using one of the following:
This pull request addresses issue #1192 for macOS.