Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: customize binary path #300

Merged
merged 2 commits into from
Jul 17, 2024
Merged

feat: customize binary path #300

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
31971e1
feat: customize binary path
kirillzyusko Jul 4, 2024
8983886
fix: TS/eslint issues
kirillzyusko Jul 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions packages/platforms/android/src/commands/platforms/UnixProfiler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,9 @@ import { processOutput as processRamOutput } from "../ram/pollRamUsage";

export const CppProfilerName = `BAMPerfProfiler`;

// Since Flipper uses esbuild, we copy the bin folder directly
// into the Flipper plugin directory
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-expect-error
const binaryFolder = global.Flipper
? `${__dirname}/bin`
: `${__dirname}/../../..${__dirname.includes("dist") ? "/.." : ""}/cpp-profiler/bin`;
const defaultBinaryFolder = `${__dirname}/../../..${__dirname.includes("dist") ? "/.." : ""}/cpp-profiler/bin`;
// Allow overriding the binary folder with an environment variable
const binaryFolder = process.env.FLASHLIGHT_BINARY_PATH || defaultBinaryFolder;

export abstract class UnixProfiler implements Profiler {
stop(): void {
Expand Down