Maker fee #64
Open
Maker fee #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ivanzhelyazkov
commented
Apr 12, 2023
ivanzhelyazkov
commented
- Add maker fee (strategy owner fee) logic
- Add maker fee tests
yudilevi
approved these changes
Apr 12, 2023
yudilevi
requested changes
Apr 12, 2023
yudilevi
approved these changes
Apr 12, 2023
barakman
requested changes
Apr 12, 2023
There was a problem hiding this comment.
Please take a closer look (carefully review) of the impact of the maker fee in function _updateStrategy.
Specifically, where value is addressed a second time:
// refund native token when there's no deposit in the order
// note that deposit handles refunds internally
if (token.isNative() && value > 0 && newOrders[i].y <= orders[i].y) {
payable(address(owner)).sendValue(value);
}
contracts/carbon/Strategies.sol
Outdated
| @@ -156,6 +158,8 @@ abstract contract Strategies is Initializable { | |||
|
|
|||
| uint256 private constant ONE = 1 << 48; | |||
|
|
|||
| uint256 private constant DEFAULT_MAKER_FEE = 5e14; // 0.0005 ETH | |||
There was a problem hiding this comment.
I believe that you can simply use 0.0005 ether
There was a problem hiding this comment.
changed to 0.0005 ether, removed comment - seems a bit clearer
contracts/carbon/Strategies.sol
Outdated
| * @dev checks if maker fee has been sent with the transaction and returns updated tx value | ||
| */ | ||
| function _deductMakerFee(bool revertOnExcess, uint256 txValue) private returns (uint256) { | ||
| uint fee = _makerFee; |
yarivbancor
approved these changes
Apr 12, 2023
barakman
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.