Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Main] Refactor upgrade files #304

Merged
merged 5 commits into from
Jun 8, 2023
Merged

[Main] Refactor upgrade files #304

merged 5 commits into from
Jun 8, 2023

Conversation

colmazia
Copy link
Contributor

Fixed: Refactor to files

Implementation details

  • Refactor upgrade to files
  • separate keeper to be its own file

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any and all appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

@RogerKSI RogerKSI changed the title [Main] Refactor [Main] Refactor upgrade files May 8, 2023
Base automatically changed from upgrade-handler-v24-to-v25 to globalfee-module May 16, 2023 06:38
@RogerKSI RogerKSI mentioned this pull request May 17, 2023
Merged
6 tasks
@RogerKSI RogerKSI requested review from taobun and removed request for taobun May 19, 2023 19:19
Base automatically changed from globalfee-module to master May 31, 2023 17:00
satawatnack
satawatnack reviewed Jun 1, 2023
View reviewed changes
app/upgrades/v2_4/upgrades.go Outdated Show resolved Hide resolved
app/upgrades/v2_6/upgrades.go Outdated Show resolved Hide resolved
app/upgrades/types.go Outdated Show resolved Hide resolved
@RogerKSI RogerKSI changed the base branch from master to update-from-25 June 1, 2023 07:18
@colmazia colmazia requested a review from satawatnack June 1, 2023 07:23
Base automatically changed from update-from-25 to master June 1, 2023 07:28
@RogerKSI RogerKSI merged commit 5f3edf1 into master Jun 8, 2023
@RogerKSI RogerKSI deleted the upgrade-handler-to-v26 branch June 8, 2023 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taobun taobun taobun approved these changes

@RogerKSI RogerKSI RogerKSI approved these changes

@satawatnack satawatnack Awaiting requested review from satawatnack

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@colmazia @RogerKSI @taobun @satawatnack