Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Cleanup code #386

Merged
merged 1 commit into from
May 21, 2024
Merged

[chore] Cleanup code #386

merged 1 commit into from
May 21, 2024

Conversation

RogerKSI
Copy link
Contributor

Implementation details

  • remove unused code
  • add mock gen command
  • add chain_id in benchmark test
  • add group module script for testing
  • add account in genesis testing file
  • adjust voting_period in genesis testing file

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any and all appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

@RogerKSI RogerKSI merged commit a44459e into master May 21, 2024
2 checks passed
@RogerKSI RogerKSI deleted the cleanup-code branch May 21, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants