Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Update to v3 + Patch cosmos sdk 0.50 #425

Merged
merged 31 commits into from
Oct 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
f224783
patch almost app
taobun Sep 4, 2024
2ab32b9
fix keeper from over undo
taobun Sep 4, 2024
f0d7bfa
able to compile chain and rewrite keeper test
taobun Sep 9, 2024
05d1fb9
wip- patch owasm test
taobun Sep 9, 2024
21327a4
add prepare and execute keeper test
taobun Sep 9, 2024
8e21d40
add app test
taobun Sep 13, 2024
c753d01
fix yoda event
taobun Sep 16, 2024
136b936
move seal config from init to setup app func
taobun Sep 16, 2024
480c178
refactor and fix from lint
taobun Sep 16, 2024
6030303
move owasm flag to oracle module remove legacy codec and getSignBytes…
taobun Sep 16, 2024
52a8465
fix from lint
taobun Sep 16, 2024
940efe8
Fix lint import order
taobun Sep 16, 2024
8b4ccdb
more fix import order
taobun Sep 16, 2024
3d8c82e
using ibc test instead of copy
taobun Sep 18, 2024
d93bd58
add bandApp shortcut and refactor util func
taobun Sep 18, 2024
ffa91aa
fix more import
taobun Sep 18, 2024
c77046d
fix import order
RogerKSI Sep 19, 2024
b3dbe8e
update golangci-lint version in ci
RogerKSI Sep 19, 2024
ab488e6
Add app_test for bank
taobun Sep 20, 2024
f93ccc2
fix from comment
taobun Sep 20, 2024
f28dc57
fix from comments
taobun Sep 23, 2024
e6bce49
fix comment
taobun Sep 23, 2024
5eb4460
remove unused dir
taobun Sep 23, 2024
91701a5
move to testing package
taobun Sep 24, 2024
609007f
Patch init command
taobun Sep 26, 2024
8649dd6
add comment
taobun Sep 26, 2024
c6479aa
Move testing app function to app helpers
taobun Sep 26, 2024
96a3cc6
move seal function to new file
taobun Sep 26, 2024
a1316b1
fix bugs from comment
taobun Sep 27, 2024
db78b63
rename import name
taobun Sep 27, 2024
5b1e942
add group module
taobun Oct 1, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/golangci-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,5 @@ jobs:
- name: golangci-lint
uses: golangci/golangci-lint-action@v6
with:
version: v1.55.2
version: v1.60
args: --timeout=5m0s
16 changes: 10 additions & 6 deletions .golangci.yml
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
run:
timeout: 5m
go: '1.22.3'
go: "1.22.3"

linters:
disable-all: true
enable:
- bodyclose
- whitespace
- errcheck
- exportloopref
- copyloopvar
- gci
- gocritic
- gofumpt
Expand All @@ -30,19 +30,24 @@ issues:
- ".*\\.pb\\.gw\\.\\.go$"
- ".*\\.pulsar\\.go$"
exclude-rules:
- text: 'Use of weak random number generator'
- text: "Use of weak random number generator"
linters:
- gosec
- text: 'ST1003:'
- text: "ST1003:"
linters:
- stylecheck

linters-settings:
gci:
custom-order: true
sections:
- standard # Standard section: captures all standard packages.
- default # Default section: contains all imports that could not be matched to another section type.
- prefix(github.com/cometbft/cometbft) # comet
- prefix(github.com/cosmos) # cosmos org
- prefix(cosmossdk.io) # new modules
- prefix(github.com/cosmos/cosmos-sdk) # cosmos sdk
- prefix(github.com/bandprotocol) # band org
- prefix(github.com/bandprotocol/chain)
gocritic:
disabled-checks:
Expand Down Expand Up @@ -99,4 +104,3 @@ linters-settings:
- G504 # Import blocklist: net/http/cgi
- G505 # Import blocklist: crypto/sha1
- G601 # Implicit memory aliasing of items from a range statement

7 changes: 6 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ test:
### Protobuf ###
###############################################################################

protoVer=0.13.0
protoVer=0.14.0
protoImageName=ghcr.io/cosmos/proto-builder:$(protoVer)
protoImage=$(DOCKER) run --rm -v $(CURDIR):/workspace --workdir /workspace $(protoImageName)

Expand All @@ -100,6 +100,11 @@ proto-lint:
proto-check-breaking:
@$(protoImage) buf breaking --against $(HTTPS_GIT)#branch=main

proto-update-deps:
@echo "Updating Protobuf dependencies"

$(DOCKER) run --rm -v $(CURDIR)/proto:/workspace --workdir /workspace $(protoImageName) buf mod update

###############################################################################
### Simulation ###
###############################################################################
Expand Down
11 changes: 6 additions & 5 deletions app/ante.go
Original file line number Diff line number Diff line change
@@ -1,16 +1,17 @@
package band

import (
ibcante "github.com/cosmos/ibc-go/v8/modules/core/ante"
ibckeeper "github.com/cosmos/ibc-go/v8/modules/core/keeper"

sdk "github.com/cosmos/cosmos-sdk/types"
sdkerrors "github.com/cosmos/cosmos-sdk/types/errors"
"github.com/cosmos/cosmos-sdk/x/auth/ante"
stakingkeeper "github.com/cosmos/cosmos-sdk/x/staking/keeper"
ibcante "github.com/cosmos/ibc-go/v7/modules/core/ante"
ibckeeper "github.com/cosmos/ibc-go/v7/modules/core/keeper"

"github.com/bandprotocol/chain/v2/x/globalfee/feechecker"
globalfeekeeper "github.com/bandprotocol/chain/v2/x/globalfee/keeper"
oraclekeeper "github.com/bandprotocol/chain/v2/x/oracle/keeper"
"github.com/bandprotocol/chain/v3/x/globalfee/feechecker"
globalfeekeeper "github.com/bandprotocol/chain/v3/x/globalfee/keeper"
oraclekeeper "github.com/bandprotocol/chain/v3/x/oracle/keeper"
)

// HandlerOptions extend the SDK's AnteHandler options by requiring the IBC
Expand Down
Loading
Loading