Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use sysconfig for sitepath #83

Merged
merged 3 commits into from
Jul 23, 2022
Merged

use sysconfig for sitepath #83

merged 3 commits into from
Jul 23, 2022

Conversation

akaszynski
Copy link
Collaborator

Resolves #79 by removing our dependency on distutils.

@codecov-commenter
Copy link

codecov-commenter commented Jun 25, 2022

Codecov Report

Merging #83 (daf080e) into main (999d9ca) will not change coverage.
The diff coverage is 75.00%.

@@           Coverage Diff           @@
##             main      #83   +/-   ##
=======================================
  Coverage   87.15%   87.15%           
=======================================
  Files           4        4           
  Lines         366      366           
=======================================
  Hits          319      319           
  Misses         47       47           

@prisae prisae mentioned this pull request Jul 22, 2022
@prisae
Copy link
Collaborator

prisae commented Jul 23, 2022

Thanks @akaszynski . I'll merge this to subsequently pull it into #85 - but before I will do some benchmarking. sysconfig seems to require a 10th of distutil to load, so we might not even have to lazy-load it any longer.

@prisae prisae merged commit c4d0742 into main Jul 23, 2022
@prisae prisae deleted the fix/use_sysconfig branch July 23, 2022 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

distutils deprecated in python 3.10
4 participants