Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename RubyVM::DebugInspector to DebugInspector and add support for truffleruby #37

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Rename RubyVM::DebugInspector to DebugInspector and add support for truffleruby #37

merged 1 commit into from
Dec 4, 2023

Conversation

eregon
Copy link
Collaborator

@eregon eregon commented Jan 24, 2023

@eregon eregon force-pushed the truffleruby-support branch from 5b01957 to 2671a4b Compare January 24, 2023 15:14
@eregon
Copy link
Collaborator Author

eregon commented Jan 24, 2023 •
edited
Loading

CI run at https://github.com/eregon/debug_inspector/actions/workflows/test.yml

@eregon eregon force-pushed the truffleruby-support branch 3 times, most recently from 831d3eb to a444abc Compare January 24, 2023 17:06
@eregon
Copy link
Collaborator Author

eregon commented Jan 24, 2023

This is now green and ready for review. cc @RobinDaugherty

@eregon
Copy link
Collaborator Author

eregon commented Feb 5, 2023

Ping, I'd love a review of this.

@eregon
Copy link
Collaborator Author

eregon commented May 29, 2023

@RobinDaugherty Ping :)

@eregon
Copy link
Collaborator Author

eregon commented Dec 1, 2023

Ping

@banister
Copy link
Owner

banister commented Dec 4, 2023

@eregon i gave you write access to this repo

@eregon
Copy link
Collaborator Author

eregon commented Dec 4, 2023

Thank you!

@eregon eregon force-pushed the truffleruby-support branch 3 times, most recently from 75bdd3f to 0253b0c Compare December 4, 2023 11:27
@eregon eregon force-pushed the truffleruby-support branch from 0253b0c to cfdf85c Compare December 4, 2023 11:28
@eregon eregon merged commit 431a3ef into banister:master Dec 4, 2023
41 checks passed
@eregon
Copy link
Collaborator Author

eregon commented Dec 4, 2023 •
edited
Loading

I should also say for clarity I'm happy to maintain this gem.

@banister I would like to make a release with this merged, let's say version 1.2.0, if that sounds OK.

I could do the release on GitHub, but we'd also need to push the gem.
Could you give me gem push permissions for this gem? (I'm eregon on rubygems.org)
Or would you prefer to push the gem yourself?

@banister
Copy link
Owner

banister commented Dec 4, 2023

Hi @eregon i added you as a gem owner, let me know if you got the link. It's a very shit UI, i'm actually shocked how terrible the rubygems UI is. Anyway, hopefully you got it.

@eregon
Copy link
Collaborator Author

eregon commented Dec 4, 2023

@banister I haven't received the email (yet?) unfortunately.
Do you see me in the list at https://rubygems.org/gems/debug_inspector/owners ?
If you need it, my email is eregontp (gmail).

@banister
Copy link
Owner

banister commented Dec 5, 2023 via email

@eregon
Copy link
Collaborator Author

eregon commented Dec 5, 2023

Thanks! That worked.

@prpetten prpetten mentioned this pull request Jan 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Renaming the module from RubyVM::DebugInspector to DebugInspector (required for TruffleRuby support)
2 participants
@eregon @banister