Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update vault_ct_image default image #61

Conversation

tanmay-pnaik
Copy link
Contributor

Overview

Update default value of vault_ct_image to hashicorp/consul-template:0.32.0 which is latest image (including support for ARM).

Signed-off-by: Tanmay Pereira Naik <tanmay.naik@thoughtworks.com>
@tanmay-pnaik tanmay-pnaik force-pushed the chore/update-consul-template-image branch from 1e77236 to 1661156 Compare July 17, 2023 10:47
Copy link
Member

@sagikazarmark sagikazarmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @tanmay-pnaik. Can you please check the question I had?

pkg/webhook/config.go Show resolved Hide resolved
@tanmay-pnaik tanmay-pnaik changed the title chore: Update vault_ct_image default image chore: Update vault_ct_image default image Jul 17, 2023
Copy link
Member

@sagikazarmark sagikazarmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@sagikazarmark sagikazarmark merged commit e563426 into bank-vaults:main Jul 18, 2023
17 checks passed
@tanmay-pnaik tanmay-pnaik deleted the chore/update-consul-template-image branch July 18, 2023 17:10
JonTheNiceGuy pushed a commit to JonTheNiceGuy/vault-secrets-webhook that referenced this pull request Sep 20, 2023
…ul-template-image

chore: Update `vault_ct_image` default image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants