Replace builtin SSL redirection with manual one #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As outlined in this (traefik/traefik#1957) issue SSL redirection with PathPrefixStrip does not work really well. A solution was provided in this (traefik/traefik#3631) PR, released in 1.7, but it didn't really solve the issue. In fact, there were several subsequent issues opened (traefik/traefik#3999, traefik/traefik#3876) but they got closed. Another issue was opened in the Traefik repo: traefik/traefik#4085 Until then this workaround provides the same functionality.
ahma
approved these changes
Oct 19, 2018
tarokkk
approved these changes
Oct 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As outlined in this
issue SSL redirection with PathPrefixStrip does not work really well.
A solution was provided in this PR,
released in 1.7, but it didn't really solve the issue.
In fact, there were several subsequent issues opened (traefik/traefik#3999, traefik/traefik#3876) but they got closed.
Another issue was opened in the Traefik repo: traefik/traefik#4085
Until then this workaround provides the same functionality.
Fixes #413