Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for one-way SSL authentication when SSL is enabled #800

Merged
merged 6 commits into from
Apr 27, 2022

Conversation

panyuenlau
Copy link
Member

Q A
Bug fix? no
New feature? yes
API breaks? no
Deprecations? no
Related tickets fixes #726
License Apache 2.0

What's in this PR?

Add support for one-way SSL authentication when SSL is enabled, this is accomplished by adding a new field, sslClientAuth, to the commonListenerSpec so the user can set the possible values (required, requested, and none) based on the Kafka broker specification

Why?

Feature requested by the community to provide one-way SSL authentication, which could be useful in some use cases

Checklist

  • Implementation tested
  • Error handling code meets the guideline
  • Logging code meets the guideline
  • User guide and development docs updated (if needed)

@panyuenlau panyuenlau requested a review from a team as a code owner April 25, 2022 23:12
api/v1beta1/common_types.go Outdated Show resolved Hide resolved
api/v1beta1/common_types.go Outdated Show resolved Hide resolved
config/samples/simplekafkacluster_with_one_way_ssl.yaml Outdated Show resolved Hide resolved
api/v1beta1/kafkacluster_types.go Outdated Show resolved Hide resolved
@panyuenlau panyuenlau requested a review from stoader April 26, 2022 15:15
pkg/resources/kafka/configmap.go Show resolved Hide resolved
@panyuenlau panyuenlau merged commit 2766fcf into banzaicloud:master Apr 27, 2022
@panyuenlau panyuenlau deleted the one-way-tls branch April 27, 2022 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for one-way TLS without client authentication
4 participants