Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for Istio 1.13 #806

Merged
merged 4 commits into from
May 6, 2022
Merged

Added support for Istio 1.13 #806

merged 4 commits into from
May 6, 2022

Conversation

Kuvesz
Copy link
Contributor

@Kuvesz Kuvesz commented May 5, 2022 •
edited
Loading

Q A
Bug fix? no
New feature? no
API breaks? no
Deprecations? no
License Apache 2.0

What's in this PR?

Updated Koperator to support Istio 1.13

Checklist

  • Implementation tested
  • Error handling code meets the guideline
  • Logging code meets the guideline

@Kuvesz Kuvesz requested a review from a team as a code owner May 5, 2022 17:10
@CLAassistant
Copy link

CLAassistant commented May 5, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

amberimam
amberimam previously requested changes May 5, 2022
View reviewed changes
Copy link

@amberimam amberimam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just found a little typo.

charts/kafka-operator/templates/crds.yaml Show resolved Hide resolved
charts/kafka-operator/templates/crds.yaml Show resolved Hide resolved
stoader
stoader requested changes May 6, 2022
View reviewed changes
Copy link
Member

@stoader stoader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the CRDs in https://github.com/banzaicloud/koperator/tree/master/config/test/crd/istio with CRDs picked from:
https://github.com/banzaicloud/istio-operator/blob/v2.13.0-rc.0/internal/assets/manifests/base/crds/crd-all.gen.yaml

https://github.com/banzaicloud/istio-operator/blob/v2.13.0-rc.0/deploy/charts/istio-operator/crds/istio-operator-crds.gen.yaml

stoader
stoader previously approved these changes May 6, 2022
View reviewed changes
bartam1
bartam1 reviewed May 6, 2022
View reviewed changes
Copy link
Contributor

@bartam1 bartam1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
These can be updated as well to 113.
https://github.com/banzaicloud/koperator/blob/istio_113/controllers/tests/kafkacluster_controller_istioingress_test.go#L69
https://github.com/banzaicloud/koperator/blob/istio_113/controllers/tests/kafkacluster_controller_istioingress_test.go#L81
https://github.com/banzaicloud/koperator/blob/istio_113/controllers/tests/kafkacluster_controller_istioingress_test.go#L419

@Kuvesz Kuvesz requested review from bartam1 and stoader May 6, 2022 13:30
@Kuvesz Kuvesz dismissed amberimam’s stale review May 6, 2022 13:44

Typo fixed :)

@Kuvesz Kuvesz merged commit f4dd94a into master May 6, 2022
@Kuvesz Kuvesz deleted the istio_113 branch May 6, 2022 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartam1 bartam1 bartam1 approved these changes

@panyuenlau panyuenlau panyuenlau approved these changes

@amberimam amberimam Awaiting requested review from amberimam

@stoader stoader Awaiting requested review from stoader

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Kuvesz @CLAassistant @amberimam @stoader @panyuenlau @bartam1