Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed apply command resource definition yaml #34

Merged
merged 1 commit into from
Mar 9, 2023
Merged

Conversation

akijakya
Copy link
Contributor

@akijakya akijakya commented Mar 8, 2023

Q A
Bug fix? yes
New feature? no
API breaks? no
Deprecations? no
Related tickets -
License Apache 2.0

What's in this PR?

Fixed generated resource definition yaml to be accepted by kubectl.

Why?

Currently when using kurun apply -f pod.yaml, the resource definition is incorrectly passed to the kubectl apply command because the runtime object is marshaled to yaml directly, resulting in something like this:

typemeta: # defines runtime property
  kind: Pod
  apiversion: v1
objectmeta: # defines runtime property
  selflink: ""
  ...

instead of this:

kind: Pod
apiversion: v1
...

Additional context

Tested locally.

Checklist

  • Code meets the Developer Guide
  • User guide and development docs updated (if needed)
  • Related Helm chart(s) updated (if needed)

@akijakya akijakya requested a review from bonifaido March 8, 2023 16:21
@akijakya akijakya self-assigned this Mar 8, 2023
@akijakya akijakya merged commit fd3ed96 into master Mar 9, 2023
@akijakya akijakya deleted the fix-apply branch March 9, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants