Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preview Message button's accessibility issue #1321

Closed
yaditya opened this issue Mar 5, 2024 · 0 comments
Closed

Preview Message button's accessibility issue #1321

yaditya opened this issue Mar 5, 2024 · 0 comments
Labels
Improvement ⚡ Something that improves existing feature. Quick to implement.

Comments

@yaditya
Copy link
Contributor

yaditya commented Mar 5, 2024 •
edited
Loading

Typebots’ Close button has been picked up as a critical accessibility issue according to aXe DevTools extension with the exact issue being Buttons must have discernible text (see the screen capture below). Upon further digging, the issue lies on this particular section where the <button class="preview-message-close-button"> element should ideally have aria-label for screen readers to be able to understand what that button does.

typebot preview message close button
@yaditya yaditya changed the title Close button's accessibility issue Preview Message button's accessibility issue Mar 5, 2024
@baptisteArno baptisteArno added the Improvement ⚡ Something that improves existing feature. Quick to implement. label Mar 5, 2024
@github-project-automation github-project-automation bot moved this to Backlog ☁️ in Typebot Mar 5, 2024
KavitaR45 pushed a commit to KavitaR45/typebot.io that referenced this issue Mar 5, 2024
@kavita2599
Fix Issue baptisteArno#1321
c1ccbdc
@yaditya yaditya mentioned this issue Mar 12, 2024
Merged
baptisteArno pushed a commit that referenced this issue Mar 12, 2024
@yaditya
🚸 Add aria-label on Bubble close button (#1344)
a9daac6 
Fix Issue
[#1321](#1321) Preview
Message button's accessibility issue
@github-project-automation github-project-automation bot moved this from Backlog ☁️ to Deployed 🎉 in Typebot Apr 7, 2024
@baptisteArno baptisteArno moved this from Deployed 🎉 to Done ✅ in Typebot Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Improvement ⚡ Something that improves existing feature. Quick to implement.
Projects
Typebot
Status: Done ✅
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yaditya @baptisteArno