Support duplicate column names #49
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barakalon
reviewed
Nov 10, 2023
| for name in inferred: | ||
| remaining.pop(name) | ||
| for name, i in inferred: | ||
| remaining.remove((name, i)) |
There was a problem hiding this comment.
Splitting hairs here, but this is O(n) when we can probably make it O(1).
Perhaps make remaining a set of (col, i)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Often times, especially during joins, you may end up with columns that have the same name, which currently does not work due to
remainingbeing a dict in_ensure_result_colswith the column name as keys. It later breaks the assertion, since one or more entries would not be aResultColumn.Sample query:
This change uses a list with name/index tuples instead of a dict.