-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JOSS Reviews: Plots do not work for flying snake example #34
Comments
Hi @OSUmageed Thank you for reporting this problem. Can you tell for how long you ran the simulation of the snake? The python script Also, note that the scripts should be run from the root directory of the simulation. cd $CUIBM_DIR/examples/flyingSnakes/Re1000AoA30
python scripts/plotForceCoefficients.py About |
Hi @mesnardo Here's the full output for the run (This is Ubuntu 16.04): I already copy pasted the original output below, but I figured it out. I'm sure you'll see it immediately but the explanation is at the bottom.
This is the forces file
Explanation.The simParams.yaml file for the flying snake simulations has nt = 10. Easy fix, but the simulation takes a while. Maybe in the examples folder there could be a Readme that tells the user which simulations take a long time to run or an option to output something like "100/1000 timesteps complete" while the simulation is running. Now they work as long as that hardwired time range is valid. |
Referring to issue #34. For long runs, we add a README in the corresponding example directories that provides the runtime obtained on a specific GPU device with information on how to change the number of time steps to run or the frequency of saving of the flow solution. Fo the flying-snake examples, we also provide information about the time range used in the Python post-processing script `plotForceCoefficients.py` to compute the mean force coefficients and Strouhal number. In the README of the project directory, we also provide the runtimes of most examples (with the type of GPU used) as well as information on how to change the number of time steps or the frequency of saving.
You are right, the simulations for the flying snake take a while to complete. Actually, I pushed a As you suggested, I also placed a README in each snake examples as well as in the flapping-wing example to let the users know that those are long runs. (I am providing the runtime for the GPU device used.) In the README of the project directory, we now provide the runtime (and the GPU used) for most examples with, again, information on how to change the number of time steps and the saving frequency. |
Looks great. |
Functionality: The plotting scripts don't work in flying snake examples.
plotForceCoefficients throws an IndexError (same error in 2.7 and 3.6):
plotVorticity just doesn't make a plot or create images folder.
The text was updated successfully, but these errors were encountered: