Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOMParser error on SSR #512

Closed
chtushar opened this issue Apr 10, 2020 · 5 comments
Closed

DOMParser error on SSR #512

chtushar opened this issue Apr 10, 2020 · 5 comments
Assignees
Labels
@barba/core @barba/core plugin bug bug to fix
Milestone

Comments

@chtushar
Copy link

I was trying to integrate barbajs with Next.js using @barba/core and @barba/router and I'm getting an error

ReferenceError: DOMParser is not defined

I'm not able to eliminate this error, please help.

@xavierfoucrier xavierfoucrier added the question questioning about a functionality or usage label Apr 10, 2020
@xavierfoucrier
Copy link
Member

Hi @chtushar,

Next.js is a React-based framework, so you don't need to use/integrate your app with Barba as this kind of framework already have router features inside: https://nextjs.org/docs/routing/introduction.

🤔

@plaidy
Copy link

plaidy commented May 5, 2020

I think I understand where @chtushar is coming from here. I'm not sure what @chtushar's context is here but I will explain mine.

Prior to using any front-end frameworks I used to use Barba.js to have more granular controls of transitions when navigating to a new page. Essentially, you wrap the portion of markup you to change between each page in a html element with the property of data-barba="container" and Barba.js will handle the heavy lifting of pre-fetching the next page and updating the portion of markup. The reason I really liked Barba.js is because it gives you access to both the current page's and next pages's mark in the DOM at the same time, this meant that you could transition on an in-out basis rather the out-in. This is illustrated in the lifecycle diagram.

Screenshot 2020-05-05 at 12 18 48

An example of an in-out could be where the content of the next page slides in and up over the current page's content. Barba also allows you to define namespaces to define the transitions on a per route basis.

It seems there is talk in #88 and the many issues referenced in that thread to implement this kind of capability. That said, there is no definitive advice on how to implement this, its seems all attempts have particular drawbacks.

@thierrymichel
Copy link
Member

As dom.ts export a "singleton", an error is throwed (server-side, I guess) because of new DOMParser() (which does not exist on Node side).
To make it work, it will need some refactoring (like creating DOMParser on-the-fly when first transition occurs, e.g.).

@xavierfoucrier xavierfoucrier added @barba/core @barba/core plugin bug bug to fix progress currently working on this issue and removed question questioning about a functionality or usage labels Jun 13, 2020
@jcolpal
Copy link

jcolpal commented Jun 13, 2020

Is it the case that barba does not play nice with reactive data in general because it will "remove the current page content from the DOM when transition is done" or are there best practices in place for using barba with reactive data?

@xavierfoucrier
Copy link
Member

Hi @jcolpal,

Barba works well with reactive data.

It "remove the current page content from the DOM" only when doing a transition.
The library offers Views and Hooks mechanisms to manage script execution before/after a transition or on specific pages.

Anyway, if you are using a front-end framework like React, Vue or Next, you should take a look at the framework documentation and use everything the framework is bringing you, like page transitions, routes, etc. instead of trying to implement another library over a complex framework layout.

I agree with @plaidy on "all attempts have particular drawbacks".

@xavierfoucrier xavierfoucrier changed the title Integration with Next.js DOMParser error on SSR Sep 7, 2020
@xavierfoucrier xavierfoucrier added this to the barba@next milestone Oct 15, 2020
@stale stale bot added the wontfix negligible issue or that will never be fixed label Dec 18, 2020
@xavierfoucrier xavierfoucrier removed the wontfix negligible issue or that will never be fixed label Dec 18, 2020
@barbajs barbajs deleted a comment from stale bot Dec 18, 2020
@stale stale bot added the wontfix negligible issue or that will never be fixed label Jun 9, 2021
@xavierfoucrier xavierfoucrier removed the wontfix negligible issue or that will never be fixed label Jun 9, 2021
@barbajs barbajs deleted a comment from stale bot Oct 4, 2021
@xavierfoucrier xavierfoucrier removed the progress currently working on this issue label Jan 31, 2022
xavierfoucrier pushed a commit that referenced this issue Nov 23, 2022
xavierfoucrier pushed a commit that referenced this issue Dec 7, 2022
xavierfoucrier pushed a commit that referenced this issue Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@barba/core @barba/core plugin bug bug to fix
Projects
None yet
Development

No branches or pull requests

5 participants