Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Tests for Get Requests #26

Merged
merged 3 commits into from
Nov 11, 2023
Merged

API Tests for Get Requests #26

merged 3 commits into from
Nov 11, 2023

Conversation

Anthony-Massaad
Copy link
Collaborator

created tests for get api requests

  • Test get for home page
  • Test get for create survey page
  • test get for view response page
  • test get for valid answer survey page
  • test get for invalid answer survey page

@Anthony-Massaad Anthony-Massaad added the Testing Testing acceptance criteria label Nov 10, 2023
@Anthony-Massaad Anthony-Massaad added this to the milestone 1 milestone Nov 10, 2023
@Anthony-Massaad Anthony-Massaad self-assigned this Nov 10, 2023
@Anthony-Massaad Anthony-Massaad linked an issue Nov 10, 2023 that may be closed by this pull request
API Tests for GET requests #24
Closed
bardia-p
bardia-p reviewed Nov 10, 2023
View reviewed changes
Copy link
Owner

@bardia-p bardia-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rename it to PageControllerTest since you are just testing the web pages? Also, can you only include the web pages that we have access to at the moment?

maxcurkovic
maxcurkovic approved these changes Nov 11, 2023
View reviewed changes
Copy link
Collaborator

@maxcurkovic maxcurkovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections. All tests look feasible

bardia-p
bardia-p reviewed Nov 11, 2023
View reviewed changes
Copy link
Owner

@bardia-p bardia-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you put these in a folder for "ControllerTests." Max will also be using the same folder for his stuff.

@Anthony-Massaad Anthony-Massaad merged commit 537ac12 into main Nov 11, 2023
1 check passed
@bardia-p bardia-p deleted the milestone1/opinionowl#24/APITestsGetRequests branch November 14, 2023 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxcurkovic maxcurkovic maxcurkovic approved these changes

@bardia-p bardia-p bardia-p approved these changes

@dorothytran dorothytran Awaiting requested review from dorothytran

Assignees

@Anthony-Massaad Anthony-Massaad

Labels
Testing Testing acceptance criteria
Projects
None yet
Milestone
milestone 1
Development

Successfully merging this pull request may close these issues.

API Tests for GET requests
3 participants
@Anthony-Massaad @bardia-p @maxcurkovic