Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UML Class Diagram Creation #27

Merged
merged 3 commits into from
Nov 11, 2023
Merged

UML Class Diagram Creation #27

merged 3 commits into from
Nov 11, 2023

Conversation

Anthony-Massaad
Copy link
Collaborator

added uml class diagram

TODO: figure out a way to add the diagrams as part of the pipeline (some automation)

@Anthony-Massaad Anthony-Massaad added the documentation Improvements or additions to documentation label Nov 10, 2023
@Anthony-Massaad Anthony-Massaad added this to the milestone 1 milestone Nov 10, 2023
@Anthony-Massaad Anthony-Massaad linked an issue Nov 10, 2023 that may be closed by this pull request
Create a UML diagram for the system. #14
Closed
bardia-p
bardia-p reviewed Nov 10, 2023
View reviewed changes
Copy link
Owner

@bardia-p bardia-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only need uml diagrams for the models not the rest.

maxcurkovic
maxcurkovic approved these changes Nov 11, 2023
View reviewed changes
Copy link
Collaborator

@maxcurkovic maxcurkovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! All the models are very accurately represented.

bardia-p
bardia-p reviewed Nov 11, 2023
View reviewed changes
Copy link
Owner

@bardia-p bardia-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the script needed to generate these? Can you make a bash and bat script for them

@Anthony-Massaad Anthony-Massaad merged commit 619b3b4 into main Nov 11, 2023
1 check passed
@bardia-p bardia-p deleted the milestone1/OpinionOwl#14/CreateUmlClassDiagram branch November 14, 2023 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxcurkovic maxcurkovic maxcurkovic approved these changes

@bardia-p bardia-p bardia-p approved these changes

@dorothytran dorothytran Awaiting requested review from dorothytran

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
milestone 1
Development

Successfully merging this pull request may close these issues.

Create a UML diagram for the system.
3 participants
@Anthony-Massaad @bardia-p @maxcurkovic