Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve Issue 70 Extra survey validation #82

Merged
merged 2 commits into from
Dec 3, 2023
Merged

Resolve Issue 70 Extra survey validation #82

merged 2 commits into from
Dec 3, 2023

Conversation

maxcurkovic
Copy link
Collaborator

I have added a few fail safes to the Create Survey JS file to check for the following:

  • Empty inputs for text questions
  • Empty inputs for radio questions
  • Empty inputs for numerical questions
  • "String" values rather than ints for numerical questions

@maxcurkovic maxcurkovic added the bug Something isn't working label Dec 3, 2023
@maxcurkovic maxcurkovic self-assigned this Dec 3, 2023
@maxcurkovic maxcurkovic added this to the milestone 3 milestone Dec 3, 2023
@Anthony-Massaad Anthony-Massaad linked an issue Dec 3, 2023 that may be closed by this pull request
Extra validation before Survey is Created #70
Closed
Anthony-Massaad
Anthony-Massaad approved these changes Dec 3, 2023
View reviewed changes
Copy link
Collaborator

@Anthony-Massaad Anthony-Massaad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulled the branch and verified the inputs. Looks good Max! And nice catch in the submit event listeners in both the editSurvey and createSurvey javascript files.

bardia-p
bardia-p approved these changes Dec 3, 2023
View reviewed changes
Copy link
Owner

@bardia-p bardia-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job Max!

@maxcurkovic maxcurkovic merged commit 6cab2be into main Dec 3, 2023
1 check passed
@bardia-p bardia-p deleted the issue70_milestone3 branch December 7, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anthony-Massaad Anthony-Massaad Anthony-Massaad approved these changes

@bardia-p bardia-p bardia-p approved these changes

@dorothytran dorothytran Awaiting requested review from dorothytran

Assignees

@maxcurkovic maxcurkovic

Labels
bug Something isn't working
Projects
None yet
Milestone
milestone 3
Development

Successfully merging this pull request may close these issues.

Extra validation before Survey is Created
3 participants
@maxcurkovic @bardia-p @Anthony-Massaad