Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented toast messages #86

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Implemented toast messages #86

merged 1 commit into from
Dec 4, 2023

Conversation

Anthony-Massaad
Copy link
Collaborator

Removed alerts and added custom toast messages instead.

Used toastr version 2.1.1 and documentation can be found here

@Anthony-Massaad Anthony-Massaad added the feature New feature or request label Dec 4, 2023
@Anthony-Massaad Anthony-Massaad added this to the milestone 3 milestone Dec 4, 2023
@Anthony-Massaad Anthony-Massaad self-assigned this Dec 4, 2023
@Anthony-Massaad Anthony-Massaad linked an issue Dec 4, 2023 that may be closed by this pull request
Create Toasts for alerts instead of alerts #84
Closed
maxcurkovic
maxcurkovic approved these changes Dec 4, 2023
View reviewed changes
Copy link
Collaborator

@maxcurkovic maxcurkovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome Tony! Think this will be a lot better than alerts

bardia-p
bardia-p approved these changes Dec 4, 2023
View reviewed changes
Copy link
Owner

@bardia-p bardia-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much Tony!

@Anthony-Massaad Anthony-Massaad merged commit f1120f6 into main Dec 4, 2023
1 check passed
@bardia-p bardia-p deleted the milestone3/issue#84/ToastMessages branch December 7, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxcurkovic maxcurkovic maxcurkovic approved these changes

@bardia-p bardia-p bardia-p approved these changes

@dorothytran dorothytran Awaiting requested review from dorothytran

Assignees

@Anthony-Massaad Anthony-Massaad

Labels
feature New feature or request
Projects
None yet
Milestone
milestone 3
Development

Successfully merging this pull request may close these issues.

Create Toasts for alerts instead of alerts
3 participants
@Anthony-Massaad @bardia-p @maxcurkovic