Upstream changes from Servo #133
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update from upstream
Incorporate 'flake8' linting via Travis CI
Register Travis webhooks with Homu
Upstream update
Allow multiple types of builders
Fix for repos not using status
|
This is a giant change in a single pull request. Also, nitpicking: Isn't barosl/homu upstream and servo a downstream fork? ;) |
|
@sigmavirus24 It isn't, there are only two changes in this PR (the rest are merge pull requests). Yes, barosl/homu is upstream, hence "upstreaming". I'm using it as a verb. |
|
Superseded by #133 |
|
Superseded by #134 |
alexcrichton
pushed a commit
to alexcrichton/homu
that referenced
this pull request
Mar 19, 2018
More logging in debug mode
This is probably excessively verbose (the `{!r}` prints out a lot of irrelevant info), but it's an improvement on the extreme lack at the moment.
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/homu/133)
<!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains changes which add flake8 linting to the CI, and a fix for #100.
The multiple build thing seems to work fine for us with appveyor.
Let me know if I should exclude something! I'd like servo/homu and homu/homu to be near-identical, with servo being a bit more liberal in accepting fixes which get eventually upstreamed to homu after style decisions and testing is done.
r? @barosl