Fix upstream dependent test failure in Laravel 11.23 and later #1595
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed test failures in Laravel 11.23 and later. The cause is the following changes on the laravel/framework side:
I addressed the issue by changing the Laravel method that we were testing.
The following points were taken into consideration when selecting the target method:
Builder
class, just like before the fix.prefer-oldest
andprefer-stable
, and is unlikely to change in the future.By satisfying these conditions, we can perform tests equivalent to
with()
, which was the target of tests before the fix.upsert
met the conditions, so I selected it.Note
This pull request, #1594, and #1591 can all be merged independently.
IMO, the following order is best:
Type of change
Checklist