Fix Laravel 5.4 support

[tortuetorche]

Fix the BindingResolutionException:

 in Container.php line 804: Target [Symfony\Component\HttpKernel\HttpKernelInterface] is not instantiable

Because, since Laravel 5.4:

the container's make method no longer accepts a second array of parameters.

We also can use this line of code, but it's only compatible with PHP >= 5.6.0:

$middleware = new $callable(...$params);

Source: http://stackoverflow.com/a/2409288

[barryvdh]

We could wait for this to be tagged: laravel/framework@5d9b363
which brings back makeWith or app($instance, $parameters)

[tortuetorche]

Oh, I wasn't aware of this makeWith() method.
Thank you Barry and have a good afternoon 👍

[tortuetorche]

Laravel 5.4.16 is released!
So to keep Laravel < 5.4 compatibility, we can do something like:

$makeMethod = method_exists($this->container, 'makeWith') ?  'makeWith' : 'make';
$middleware = $this->container->$makeMethod($callable, $params);

@barryvdh What do you think about this?

[barryvdh]

Sounds good

[barryvdh]

Ready to go?

[tortuetorche]

No, I need to do some manual tests...

[tortuetorche]

The Container::makeWith() method doesn't work as expected and I don't know why yet.

[tortuetorche]

I successfully call the Container::makeWith() method with some modifications:

In vendor/barryvdh/laravel-stack-middleware/src/StackMiddleware.php file:

            // Add kernel as 'app' parameter
            $params['app'] = $kernel;
            $makeMethod = method_exists($this->container, 'makeWith') ?  'makeWith' : 'make';
            $middleware = $this->container->$makeMethod($callable, $params);

And in my Turbolinks Service Provider vendor/efficiently/turbolinks/src/Frenzy/Turbolinks/TurbolinksServiceProvider.php, I replace this code:

        $stack->bind(
            'Frenzy\Turbolinks\Middleware\StackTurbolinks',
            'Helthe\Component\Turbolinks\StackTurbolinks',
            [$this->app['turbolinks']]
        );

By this one:

        $stack->bind(
            'Frenzy\Turbolinks\Middleware\StackTurbolinks',
            'Helthe\Component\Turbolinks\StackTurbolinks',
            ['turbolinks' => $this->app['turbolinks']]
        );

See StackTurbolinks::__construct() method, for more information.

The $params parameter, of Container::makeWith() method, need to have named keys, but I don't know why...

[tortuetorche]

I've open an issue on the Laravel Framework repository, see: laravel/framework#18474

[tortuetorche]

According to @themsaid laravel/framework#18474 (comment),

With Container::makeWith() method, you have to pass the parameter name.

So it's a breaking change compared to the behavior of Container::make() of Laravel 5.3.
Because instead of binding Laravel Stack Middleware, like this:

        $stack->bind(
            'Frenzy\Turbolinks\Middleware\StackTurbolinks',
            'Helthe\Component\Turbolinks\StackTurbolinks',
            [$this->app['turbolinks']]
        );

We need to bind Laravel Stack Middleware, like that:

        $stack->bind(
            'Frenzy\Turbolinks\Middleware\StackTurbolinks',
            'Helthe\Component\Turbolinks\StackTurbolinks',
            ['turbolinks' => $this->app['turbolinks']]
        );

[barryvdh]

OK can you update the pr?

[tortuetorche]

@barryvdh Done, but these breaking changes should be documented in the README.md

[barryvdh]

Is it breaking?

[tortuetorche]

When I said "it's a breaking change", I mean, you can't do this anymore:

app('stack')->bind('AddRobotsHeaders', 'League\StackRobots\Robots', ['production', 'APP_ENV']);

Instead, you need to do this:

app('stack')->bind('AddRobotsHeaders', 'League\StackRobots\Robots', ['env' => 'production', 'envVar' => 'APP_ENV']);