clamp: Turn ifelse into ternary

Fixes JuliaLang#54022 Co-authored-by: Klaus Crusius <KlausC@users.noreply.github.com>
barucden · Apr 12, 2024 · 6156be8 · 6156be8
1 parent 630f754
commit 6156be8
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/base/math.jl b/base/math.jl
@@ -95,11 +95,10 @@ julia> clamp.([11, 8, 5], 10, 6)  # an example where lo > hi
  10
 ```
 """
-clamp(x::X, lo::L, hi::H) where {X,L,H} =
-    ifelse(x > hi, convert(promote_type(X,L,H), hi),
-           ifelse(x < lo,
-                  convert(promote_type(X,L,H), lo),
-                  convert(promote_type(X,L,H), x)))
+function clamp(x::X, lo::L, hi::H) where {X,L,H}
+    T = promote_type(X, L, H)
+    return (x < lo) ? convert(T, lo) : (x > hi) ? convert(T, hi) : x
+end
 
 """
     clamp(x, T)::T

diff --git a/test/math.jl b/test/math.jl
@@ -47,6 +47,9 @@ has_fma = Dict(
         clamp!(x, 1, 3)
         @test x == [1.0, 1.0, 2.0, 3.0, 3.0]
     end
+
+    @test clamp(typemax(UInt64), Int64) === typemax(Int64)
+    @test clamp(typemin(Int), UInt64) === typemin(UInt64)
 end
 
 @testset "constants" begin